Remove middleware submodule #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new cookies submodule, and axes several unused types. Thanks!
yoshuawuyts
force-pushed
the
remove-middleware-submodule
branch
from
96e4b3f
to
ac7a70c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the entirety of the middleware submodule in favor of named submodules similar to
http-types. This also further continues the rename of our middleware to start withMiddleware*and sets us up for integratingCorsMiddlewarewith thehttp_types::security::*values.This PR depends on #451 to land first, which moves the logging middleware out of the
middlewaresubmodule. Thanks!