bind to an unused port in integration tests #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Apr 22, 2020
tests/chunked-encode-large.rs
Outdated
| @@ -67,22 +68,23 @@ const TEXT: &'static str = concat![ | |||
|
|
|||
| #[async_std::test] | |||
| async fn chunked_large() -> Result<(), http_types::Error> { | |||
| let server = task::spawn(async { | |||
| let bind = test_utils::determine_port_to_bind().await; | |||
There was a problem hiding this comment.
Can we rename the bind variable to port?
There was a problem hiding this comment.
would socket_addr work? I initially had port (as still remains in the function name, which will also be fixed), but it's both localhost as well as the port
tests/test_utils.rs
Outdated
| @@ -0,0 +1,7 @@ | |||
| pub async fn determine_port_to_bind() -> async_std::net::SocketAddr { | |||
There was a problem hiding this comment.
A more concise name would be find_port, would you mind changing that?
There was a problem hiding this comment.
as with above comment, would find_socket_addr be reasonably concise and clear? it's really something like "find a port and return a socket addr with that port" but that's awkward af
and rename `bind` variable names to `port`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if a machine has a server running on any of the ports used for testing (808x), tests would fail in unclear ways. Because socket reuse flags are platform dependent, this PR finds an unused port by temporarily binding to port 0 and using the assigned port.