Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of async_closure #289

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Jul 15, 2019

Description

Motivation and Context

async_closure won't be stable any time soon and are equivalent to closures which return async blocks.

Related: rust-lang/futures-rs#1716 (comment)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@secretfader
Copy link

I recently added the async_closure feature flag to http-service during an effort to fix builds on recent nightlies, and I'm happy to remove it if this is merged. Anything that moves us towards stability sooner rather than later gets my vote. 👍

@fairingrey
Copy link
Contributor

This looks pretty simple enough, thanks for the help! 👍

I'll be looking at updating other libraries in rust-async to follow this change soon, probably.

@fairingrey fairingrey merged commit ff9731c into http-rs:master Jul 15, 2019
@taiki-e taiki-e deleted the async_closure branch July 15, 2019 20:01
@secretfader
Copy link

Since this feature gate is currently deferred, I favor moving other libraries to match the standard set by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants