fix: Capture wildcard path correctly, resolve #167. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c70d2bc resolved the panic raised in the issue, but it also exposed my ignorance with regards to route-recognizer, our new routing library. Placing the * after a named param, as it was in the original example, leads to the behavior mentioned in http-rs#167. route-recognizer is operating exactly as intended. `:path*` doesn't capture additional URL segments, where `*path` does.
|
@yoshuawuyts Glad to help. I just wish I hadn't misunderstood how route-recognizer works. (I'd like to improve docs if/when we migrate that crate to @rustasync.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c70d2bc resolved the panic raised in the issue, but it also exposed my
ignorance with regards to route-recognizer, our new routing library.
Placing the
*after a named param, as it was in the original example,leads to the behavior mentioned in #167. route-recognizer is operating
exactly as intended.
:path*doesn't capture additional URL segments,where
*pathdoes. (It also appends*to the parameter key, as well.)