Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AsRef and Into conversions between tide Requests/Responses and their inner http_types equivalents #465

Closed
7 of 8 tasks
jbr opened this issue Apr 24, 2020 · 0 comments · Fixed by #670
Closed
7 of 8 tasks
Labels
good first issue Good for newcomers

Comments

@jbr
Copy link
Member

jbr commented Apr 24, 2020

this is the tide mirror issue of http-rs/surf#167
this allows for an escape hatch to drop down to apis that might not need to be exposed at the tide level. this would also allow for better interop between surf and tide, such as providing concise support for proxy operations (receive a surf::Response, unwrap it into an http_types::Response, and re-wrap that as a tide::Response)

  • tide::Request -> http_types::Request
    • Into
    • AsRef
  • tide::Response -> http_types::Response
    • Into
    • AsRef
  • http_types::Response -> tide::Response (Into)
  • http_types::Request -> tide::Request (Into)
Fishrock123 added a commit to Fishrock123/tide that referenced this issue May 17, 2020
Fishrock123 added a commit to Fishrock123/tide that referenced this issue May 17, 2020
@jbr jbr changed the title tide http_types wrappers are not currently able to be unwrapped Implement AsRef and Into conversions between tide Requests/Responses and their inner http_types equivalents May 17, 2020
Fishrock123 added a commit to Fishrock123/tide that referenced this issue May 17, 2020
Fishrock123 added a commit to Fishrock123/tide that referenced this issue May 17, 2020
Fishrock123 added a commit to Fishrock123/tide that referenced this issue May 17, 2020
Fishrock123 added a commit to Fishrock123/tide that referenced this issue May 17, 2020
Fishrock123 added a commit to Fishrock123/tide that referenced this issue May 17, 2020
Fishrock123 added a commit to Fishrock123/tide that referenced this issue May 17, 2020
@Fishrock123 Fishrock123 added the good first issue Good for newcomers label Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants