Implement Sink trait based upon work in tide-websockets PRs #3 and #9. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #9 (comment) |
|
@jbr I don't understand how that solves my use-case. Can you explain how I would adjust my code to use your library? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work should be included to support shared mutable references across thread contexts.
An example is included from before, but for a more practical example, please see:
ChainSafe/forest@ff2691b#diff-2770a30d9f259666fb470d6f11cf1851ebb2d579a1480a8173d3855572748385
And in particular, this case:
https://github.com/ChainSafe/forest/blob/ff2691bab92823a8595d1d456ed5fa9683641d76/node/rpc/src/rpc_ws_handler.rs#L33
See also: #3 #9