Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade rust_2018_idioms from forbid to warn #245

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Downgrade rust_2018_idioms from forbid to warn #245

merged 1 commit into from
Sep 29, 2020

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Sep 29, 2020

@taiki-e taiki-e mentioned this pull request Sep 29, 2020
Closed
yoshuawuyts
yoshuawuyts approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps!

@yoshuawuyts yoshuawuyts merged commit 24d7ad0 into http-rs:main Sep 29, 2020
@taiki-e taiki-e deleted the rust_2018_idioms branch September 29, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forbidding 2018 idioms Incompatible with pin_project_lite 0.1.9
2 participants
@taiki-e @yoshuawuyts