re-export `http_types::{Error, Result}` at the crate root #163

goto-bus-stop · 2020-04-22T08:27:07Z

So you can easily refer to it directly, like:

async fn some_fn_that_makes_a_request() -> Result<(), surf::Error> {}

instead of needing a separate

use surf::http_types::Error as HttpError;

So you can easily refer to it directly, like: ```js async fn some_fn_that_makes_a_request() -> Result<(), surf::Error> {} ``` instead of needing a separate ```js use surf::http_types::Error as HttpError; ```

yoshuawuyts

LGTM, perhaps http_types::Result could be included as well?

re-export http_types::Error at the crate root

f9b09cb

So you can easily refer to it directly, like: ```js async fn some_fn_that_makes_a_request() -> Result<(), surf::Error> {} ``` instead of needing a separate ```js use surf::http_types::Error as HttpError; ```

yoshuawuyts approved these changes Apr 22, 2020

View reviewed changes

also reexport Result

12951e4

goto-bus-stop changed the title ~~re-export http_types::Error at the crate root~~ re-export http_types::{Error, Result} at the crate root Apr 22, 2020

goto-bus-stop merged commit 2fd9f75 into master Apr 22, 2020

goto-bus-stop deleted the reexport-error branch April 22, 2020 08:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

re-export `http_types::{Error, Result}` at the crate root #163

re-export `http_types::{Error, Result}` at the crate root #163

goto-bus-stop commented Apr 22, 2020 •

edited

Loading

yoshuawuyts left a comment

re-export http_types::{Error, Result} at the crate root #163

re-export http_types::{Error, Result} at the crate root #163

Conversation

goto-bus-stop commented Apr 22, 2020 • edited Loading

yoshuawuyts left a comment

Choose a reason for hiding this comment

re-export `http_types::{Error, Result}` at the crate root #163

re-export `http_types::{Error, Result}` at the crate root #163

goto-bus-stop commented Apr 22, 2020 •

edited

Loading