Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test <div><table><svg><foreignObject><select><table><s> #163

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Test <div><table><svg><foreignObject><select><table><s> #163

merged 1 commit into from
Apr 27, 2023

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Apr 5, 2023

Closes #137.

@annevk
Copy link
Contributor Author

annevk commented Apr 5, 2023

Analysis at #137 (comment).

@annevk annevk requested review from zcorpan and hsivonen April 14, 2023 17:35
@annevk annevk merged commit 31086ec into html5lib:master Apr 27, 2023
@annevk annevk deleted the annevk/ms2ger-found-something branch April 27, 2023 14:49
@flavorjones flavorjones mentioned this pull request Apr 27, 2023
Closed
@flavorjones
Copy link
Contributor

This test does not specify the appropriate number of errors, and is failing downstream. I'll send a PR shortly.

@annevk
Copy link
Contributor Author

annevk commented Apr 27, 2023

Yeah sorry, browsers don't care about errors so it's hard to get those right. Happy to consider changes to the process to make that better for everyone.

flavorjones added a commit to flavorjones/html5lib-tests that referenced this pull request Apr 27, 2023
@flavorjones
Provide errors for test introduced in html5lib#163
12a31b3
@flavorjones flavorjones mentioned this pull request Apr 27, 2023
Merged
@flavorjones
Copy link
Contributor

@annevk It seems likely that #154 and the other "downstream" github actions PRs would help with those feedback loops, and help understand whether parser implementations differ on the errors generated.

annevk pushed a commit that referenced this pull request Apr 27, 2023
@flavorjones
Provide errors for test introduced in #163
66f49b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcorpan zcorpan zcorpan approved these changes

@hsivonen hsivonen Awaiting requested review from hsivonen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compat issue: <div><table><svg><foreignObject><select><table><s>
3 participants
@annevk @flavorjones @zcorpan