Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add a skeleton github actions workflow for downstream projects #153

Merged

Conversation

flavorjones
Copy link
Contributor

This is one idea to start a CI suite for downstream tests, see the conversation at #141.

The goal here is to have a skeleton workflow that can be manually inspected by the maintainers and merged onto master. Once this file is on master, then subsequent PRs that modify the workflow file will (unless configured otherwise) run the workflow on the PR, which is the end goal of #141.

This workflow follows some practices that I've found useful:

  • the concurrency section means that if a push to an existing PR or to master happens while the workflow is running, the run is canceled and new one is kicked off
  • on: workflow_dispatch means that you can kick off a test run manually via Github's web UI
  • the on: push section will run the workflow on any push to master
  • the on: pull_request section will run the workflow just once for any change to a PR ("open" or "synchronize") -- by default GA will run the workflow twice when commits are pushed onto an existing PR

And the final jobs section is just a placeholder job that can be removed after this is merged.

@sideshowbarker sideshowbarker merged commit 95417e6 into html5lib:master Mar 14, 2023
@flavorjones flavorjones deleted the flavorjones-skeleton-ga-workflow branch March 14, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants