Test spec change: Remove parse error for <template><tr></tr> </template> #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcorpan
reviewed
Sep 8, 2022
zcorpan
reviewed
Sep 8, 2022
3 tasks
|
@zcorpan thank you for feedback, fixed, not sure about the error message (because they are different in different tests and don't align to spec errors) + added tests case for own parser (and works as expected) |
zcorpan
reviewed
Sep 13, 2022
Co-authored-by: Simon Pieters <[email protected]>
|
@zcorpan Fixed, do I need update something else (or more tests)? |
zcorpan
approved these changes
Sep 14, 2022
|
Waiting for the spec pr to merge, I assume. |
|
Yep |
zcorpan
changed the title
flavorjones
added a commit
to sparklemotion/nokogiri
that referenced
this pull request
Oct 21, 2022
and update to the latest html5lib-tests See: - whatwg/html#7922 - whatwg/html#8271 - html5lib/html5lib-tests#150 - html5lib/html5lib-tests#151
flavorjones
added a commit
to sparklemotion/nokogiri
that referenced
this pull request
Oct 21, 2022
and update to the latest html5lib-tests See: - whatwg/html#7922 - whatwg/html#8271 - html5lib/html5lib-tests#150 - html5lib/html5lib-tests#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: whatwg/html#7922