-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix install requirements #52
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 5 5
Lines 578 578
=======================================
Hits 476 476
Misses 102 102 ☔ View full report in Codecov by Sentry. |
Nice, thanks @AdamOrmondroyd! Clearly, I have been neglecting the If you felt like it you could rewrite |
Feel free to merge if you're not up for the |
I'm reluctant to get too involved aha, I only stumbled on this from helping Dily |
@AdamOrmondroyd No problem hahaa it's not super important! |
I don't think I have permission to merge (and I'm partial to a green square) |
Hmm I think I added you as a collaborator so you can probably do it now... |
Hm I don't have a button |
Might be worth pushing this to pypi so that |
Yeah I'll sort it! Thanks @AdamOrmondroyd! 😄 |
@AdamOrmondroyd Didn't bump the version number 😢 I'll push to master... bit cheeky but I'm allowing it 😆 |
@htjb needs a test to check it's incremented... just nick the anesthetic one |
@AdamOrmondroyd Yeah I have one for globalemu thanks to @ThomasGesseyJones who may have also done the anesthetic one as well hahaa. Been on my margarine to-do list but haven't got to it yet. |
Hi @AdamOrmondroyd and @htjb , PR #53 adds the requested version control workflow (copied from the globalemu repository). Can one of you review the code before I merge? For the record, I did not write the anesthetic version control workflow, at the time of writing the only workflow I have been involved with for that project was the automatic GitHub release workflow. |
The
install_requires
argument insetup.py
is missing several requirements which are present inrequirements.txt
:anesthetic
,scikit-learn
,tqdm
, and the platform-specifictensorflow
.torch
was also missing from bothsetup.py
andrequirements.txt
.