Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(to_cpp1): extend move supression to member access #676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented Sep 14, 2023

Resolves #558.

Testing summary:

100% tests passed, 0 tests failed out of 818

Total Test time (real) =  50.70 sec

Acknowledgements:

@JohelEGP JohelEGP force-pushed the suppress_move_from_last_use branch from d2939ac to cbcd5a0 Compare September 22, 2023 22:17
@JohelEGP JohelEGP changed the title fix(cpp1): extend move supression to member access fix(to_cpp1): extend move supression to member access Nov 9, 2023
@JohelEGP JohelEGP force-pushed the suppress_move_from_last_use branch from cbcd5a0 to 48f643a Compare November 9, 2023 21:59
@hsutter
Copy link
Owner

hsutter commented Oct 31, 2024

Hi! Sorry it took me so long to get to this one... but this is really tactical and looks like it might still be current, modulo the conflict.

Is this up to date (after resolving the merge conflict), and would you like me to review it?

@hsutter hsutter added the question - further information requested Further information is requested label Oct 31, 2024
@JohelEGP JohelEGP force-pushed the suppress_move_from_last_use branch from 48f643a to b8c233b Compare October 31, 2024 22:51
@JohelEGP
Copy link
Contributor Author

Yes, and yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question - further information requested Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Implicit move before taking address of member
2 participants