Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix clang++-15 regression test job #1077

Merged

Conversation

bluetarpmedia
Copy link
Contributor

Updated expected results for clang++-15 on ubuntu-latest.

@hsutter
Copy link
Owner

hsutter commented May 22, 2024

Thanks! But a question: Clang-15 no longer works with formatted interpolation?

@bluetarpmedia
Copy link
Contributor Author

bluetarpmedia commented May 22, 2024

Thanks! But a question: Clang-15 no longer works with formatted interpolation?

That's because it's now using the libstdc++ from gcc 12. Previously it was using libstdc++ from gcc 13. So it's not really a clang compiler issue but the version of the standard library that it uses.

Something changed with the GitHub Action ubuntu images which means gcc 13 is no longer available on ubuntu-latest, so clang now picks up the highest version of gcc that is installed (12) and uses that version of libstdc++.

I figured the best option for now is to fix this regression test job, but I've made a note to improve things:

  1. Stop using ubuntu-latest since over time this "pointer" will change, and we won't have consistent results. Instead I think it's better to use explicit versions

  2. I think we need to add tests for clang and libc++ (the LLVM standard library), instead of (or in addition to) clang with libstdc++.

EDIT - Just realised that 2nd case is covered already on macOS, but not ubuntu. So maybe not as important as I thought.

@hsutter
Copy link
Owner

hsutter commented May 22, 2024

Sounds good, thanks for paying attention to this! Appreciated.

@hsutter hsutter merged commit d3ad31a into hsutter:main May 22, 2024
16 of 17 checks passed
@bluetarpmedia bluetarpmedia deleted the ci-update-clang15-ubuntu-results branch May 23, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants