Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show less context on failure #26

Closed
voidus opened this issue Jun 1, 2023 · 2 comments
Closed

Show less context on failure #26

voidus opened this issue Jun 1, 2023 · 2 comments

Comments

@voidus
Copy link

voidus commented Jun 1, 2023

Currently, hedgehog always shows the whole toplevel definition on failure (as far as I can tell)

in a long definition with a bunch of describes, this is a lot of stuff we probably don't care about.

I think it would be better to only show the innermost it-call. Not sure if this requires a change with hedgehog though.

@sol
Copy link
Member

sol commented Jun 2, 2023

This is something I would love to see as well.

From what I understand, the code that extracts the definitions is here: https://github.com/hedgehogqa/haskell-hedgehog/blob/master/hedgehog/src/Hedgehog/Internal/Discovery.hs#L44

If we don't want to reimplement all of the result formatting then I guess we would need to make this configurable in hedgehog somehow.

@sol
Copy link
Member

sol commented Oct 22, 2023

Draft PR: #29

sol added a commit that referenced this issue Nov 21, 2023
sol added a commit that referenced this issue Nov 21, 2023
sol added a commit that referenced this issue Apr 3, 2024
sol added a commit that referenced this issue Apr 3, 2024
sol added a commit that referenced this issue May 2, 2024
sol added a commit that referenced this issue May 2, 2024
sol added a commit that referenced this issue May 11, 2024
sol added a commit that referenced this issue Jul 26, 2024
sol added a commit that referenced this issue Jul 27, 2024
sol added a commit that referenced this issue Jul 27, 2024
@sol sol closed this as completed in 5c93445 Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants