Rewrite safe-docker in Python #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skogsbaer
approved these changes
Sep 10, 2024
The string ${TASK_ID} will then be replaced with the specified custom id
of a task. If it is not given, the string for the external directory is
not altered.
Instead of having to tie the underlying ID of a task to the task title
(or some id generated by the database), we can specify a custom id that
is not visible to the user.
This id is also available as an environment variable within a checker as
TASK_ID_CUSTOM.
hannesbraun
force-pushed
the
safe-docker-python
branch
from
08be1e5 to
e33dffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the safe-docker script in Python. This way, we can get rid of Perl as a dependency and this probably also results in an easier implementation of the Docker integration.
This branch includes the changes from #61 (which should be merged first) to circumvent merge conflicts. Hence the diff currently includes changes that don't belong to this feature.