-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: create IceFlow nodes based on application DAG #109
Conversation
6b07de9
to
47e3d1f
Compare
I think this PR should now be ready for an initial review. The changes might have turned a bit more drastic (and in some places even controversial) than I originally intended, but I think this should point into the right direction. Some of the most important aspects:
Looking forward to your feedback – if you like, I can also walk you through the PR on Monday. |
Applied some further adjustments to the prosumer callback registration, that allows the user to specify which downstream edge they to push to, in order to make to it possible to push data to multiple downstream edges at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few more spots that might require discussion below.
b6bba91
to
7be7684
Compare
I think after the recent commits, this PR should now be ready for (hopefully) a final review :) |
18e39b9
to
23400f4
Compare
(Just spend about 15 minutes debugging some newly appearing errors involving segmentation faults – in the end, the fix came down to a6c21c5 🤦 This is always great fun :D) |
When the pipeline succeeds, I am now going to finally squash and merge this PR :) |
0ff8b21
to
e252514
Compare
This is the follow-up PR to #107, which attempts to perform an overhaul of the IceFlow API using our application DAG. This PR is still heavily WIP and gradually incorporate further changes made to #107.