Make performance improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 141 145 +4
=========================================
+ Hits 141 145 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It's got a relatively large import time, mostly because it's using regexes under-the-hood. Use `sys.platform` instead. `sys` is already imported and has the platform as an attribute.
We don't need to spend time importing these unless we know we're looking for a poetry venv.
Hand role an enum so we can avoid the import.
This saves ~0.03 ms, which is a ~25% speed-up. It's a shame, because I like the pathlib API, but speed is king for this application.
This avoids another import, as saves a millisecond or two.
A very minor optimisation, that means we're not repeating the logic used to get the current operating system.
We can quite happily deal with relative paths.
This reverts commit 05182ef. This introduced a bug where entering a sub-directory would deactivate the environment.
hsaunders1904
force-pushed
the
make_performance_improvements
branch
from
690f97d to
af3ea42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.