-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.6 #17
Add support for Python 3.6 #17
Conversation
04b66a8
to
7d53728
Compare
Hi @thevahidal, thanks for your contribution, I'm glad you've found |
Great, let me know if I can help with anything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks again for your contribution, sorry for taking so long to get back to you, I haven't had a huge amount of time over the last few weeks.
I've been struggling with this a bit. Python 3.6 is very old now and is not supported by poetry or ruff; two things I'd rather not drop.
That said, I'm happy to accept your changes to the main script (with a few tweaks), so it should run with 3.6. I'll try not to introduce any changes that break things for you, but I won't be "officially" supporting 3.6.
Yeah, I totally understand and respect your decision. Thanks though that you're willing to accept these changes! |
980f6b1
to
d0079d9
Compare
I did a new push with all the changes you asked. |
d0079d9
to
2233f20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @thevahidal
🙏 |
Hi @hsaunders1904,
I just found your repo and wanted to thank you for creating it, it's amazing!
In my company, we have some legacy projects which still use Python 3.6, and I needed to add support for it in
pyautoenv
.Here are the changes I made, please review them and let me know if you agree with supporting 3.6.
Thanks again!