Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.6 #17

Merged

Conversation

thevahidal
Copy link
Contributor

Hi @hsaunders1904,
I just found your repo and wanted to thank you for creating it, it's amazing!

In my company, we have some legacy projects which still use Python 3.6, and I needed to add support for it in pyautoenv.
Here are the changes I made, please review them and let me know if you agree with supporting 3.6.

Thanks again!

@thevahidal thevahidal force-pushed the add-support-for-python-3.6 branch 2 times, most recently from 04b66a8 to 7d53728 Compare July 25, 2024 11:04
@hsaunders1904
Copy link
Owner

Hi @thevahidal, thanks for your contribution, I'm glad you've found pyautoenv useful. I'm happy to accept your changes, however the test infrastructure currently uses poetry, which only supports Python 3.8 and above. I'll have to have a little think about how to update the test infrastructure, then I'll get back to you.

@thevahidal
Copy link
Contributor Author

Great, let me know if I can help with anything!

Copy link
Owner

@hsaunders1904 hsaunders1904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks again for your contribution, sorry for taking so long to get back to you, I haven't had a huge amount of time over the last few weeks.

I've been struggling with this a bit. Python 3.6 is very old now and is not supported by poetry or ruff; two things I'd rather not drop.

That said, I'm happy to accept your changes to the main script (with a few tweaks), so it should run with 3.6. I'll try not to introduce any changes that break things for you, but I won't be "officially" supporting 3.6.

README.md Outdated Show resolved Hide resolved
pyautoenv.py Outdated Show resolved Hide resolved
pyautoenv.py Outdated Show resolved Hide resolved
pyautoenv.py Outdated Show resolved Hide resolved
pyautoenv.py Outdated Show resolved Hide resolved
tests/test_poetry.py Outdated Show resolved Hide resolved
tests/test_poetry.py Outdated Show resolved Hide resolved
pyautoenv.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyautoenv.py Outdated Show resolved Hide resolved
@thevahidal
Copy link
Contributor Author

Yeah, I totally understand and respect your decision. Thanks though that you're willing to accept these changes!

@thevahidal thevahidal force-pushed the add-support-for-python-3.6 branch 2 times, most recently from 980f6b1 to d0079d9 Compare August 18, 2024 22:11
@thevahidal
Copy link
Contributor Author

I did a new push with all the changes you asked.

pyautoenv.py Outdated Show resolved Hide resolved
@thevahidal thevahidal force-pushed the add-support-for-python-3.6 branch from d0079d9 to 2233f20 Compare August 19, 2024 18:39
Copy link
Owner

@hsaunders1904 hsaunders1904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @thevahidal

@hsaunders1904 hsaunders1904 merged commit be32cb2 into hsaunders1904:main Aug 19, 2024
2 checks passed
@thevahidal
Copy link
Contributor Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants