Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added current_observation property to AbstractBattle #639

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

caymansimpson
Copy link
Contributor

This is important for battle parsing when there's a force switch; an agent needs to be able to access the logs in the current turn to assess the battle state and understand what it needs to do next.

Mentioned here: #630

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (f458350) to head (203e510).
Report is 80 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage   83.38%   85.44%   +2.06%     
==========================================
  Files          39       42       +3     
  Lines        3918     4302     +384     
==========================================
+ Hits         3267     3676     +409     
+ Misses        651      626      -25     

@hsahovic hsahovic merged commit 51a25e6 into hsahovic:master Nov 18, 2024
3 of 8 checks passed
@caymansimpson caymansimpson deleted the current_obs branch November 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants