Added correct handling for pledge moves #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 83.38% 85.65% +2.27%
==========================================
Files 39 42 +3
Lines 3918 4301 +383
==========================================
+ Hits 3267 3684 +417
+ Misses 651 617 -34 |
hsahovic
reviewed
Nov 17, 2024
| ["", "switch", "p2a: Primarina", "Primarina, L50, F, shiny", "169/169"], | ||
| ["", "switch", "p2b: Decidueye", "Decidueye-Hisui, L50, F, shiny", "171/171"], | ||
| ["", ""], | ||
| ["", "-terastallize", "p2a: Primarina", "Poison"], |
There was a problem hiding this comment.
why tera here? or is it just copied from a raw battle log?
There was a problem hiding this comment.
Ah yeah 😅 I just copied it from my fuzz testing logs. I can edit it down for clarity!
hsahovic
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, pledge moves are incorrectly handled and overrode, so that if Piplup used Water Pledge and Cyndaquil followed up with Fire Pledge, we would set Cyndaquil's move as Water Pledge. This is a problem when we update the mon with a request, because there'd be a conflict of moves and it will raise a Error
Mentioned here: #628