Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added further Effects handling from Showdown parsing and fainting #596

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

caymansimpson
Copy link
Contributor

We add three things:

  1. Parsing of -singlemove (showdown protocol and -singleturn (showdown protocol)
  2. Effect Handling for when a pokemon faints (we should remove all effects since they are no longer relevant to the battle state)
  3. Tests for these

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (f458350) to head (c48ce66).
Report is 69 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   83.38%   85.40%   +2.02%     
==========================================
  Files          39       42       +3     
  Lines        3918     4303     +385     
==========================================
+ Hits         3267     3675     +408     
+ Misses        651      628      -23     

@hsahovic hsahovic merged commit 70bf850 into hsahovic:master Sep 3, 2024
8 checks passed
@caymansimpson caymansimpson deleted the effects branch September 3, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants