Added Effect Handling, and reordered a set for lint #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue here
This just removes Effects when they silently get removed in the true battle state, but Showdown doesn't send you a log. Like all effects, testing is quite manual and maintenance is hard given that each effect is typically a unique edge-case.
However, this is 95% there and unblocks reverse speed/damage calculation
I also reordered items added to a set in abstract_battle to be consistent