Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Effect Handling, and reordered a set for lint #593

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

caymansimpson
Copy link
Contributor

Issue here

This just removes Effects when they silently get removed in the true battle state, but Showdown doesn't send you a log. Like all effects, testing is quite manual and maintenance is hard given that each effect is typically a unique edge-case.

However, this is 95% there and unblocks reverse speed/damage calculation

I also reordered items added to a set in abstract_battle to be consistent

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (f458350) to head (6068970).
Report is 65 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
+ Coverage   83.38%   85.38%   +2.00%     
==========================================
  Files          39       42       +3     
  Lines        3918     4298     +380     
==========================================
+ Hits         3267     3670     +403     
+ Misses        651      628      -23     

@hsahovic hsahovic merged commit d077fd2 into hsahovic:master Sep 1, 2024
8 checks passed
@hsahovic
Copy link
Owner

hsahovic commented Sep 1, 2024

Thanks @caymansimpson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants