Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Move SideConditions and corrected protect classifications #557

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

caymansimpson
Copy link
Contributor

Did a couple of small things:

  1. Fixed Protect Classifications, according to Bulbapedia
  2. Added SideConditions found in Moves that weren't previously recorded (collected through regex filtering of gen[1-9]moves.json)
  3. Fixed move.side_condition to return a SideCondition object, consistent with Terrain/Weather/Effect/Status
  4. Added tests for SideCondition to ensure better maintainability, similar to what I did with volatile_status -- ensuring that if a new SideCondition pops up, we will have it captured in the enum. Also ensuring that we don't have extra SideConditions not available in Showdown
  5. Added small functionality to move_generator in test_move so that we can more easily test different generations of moves to ensure multi-generational compatibility

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (f458350) to head (e26da2b).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   83.38%   84.56%   +1.17%     
==========================================
  Files          39       42       +3     
  Lines        3918     4198     +280     
==========================================
+ Hits         3267     3550     +283     
+ Misses        651      648       -3     

@hsahovic hsahovic merged commit 05863e0 into hsahovic:master Jun 10, 2024
8 checks passed
@caymansimpson caymansimpson deleted the side_conditions branch June 11, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants