Fixed Move SideConditions and corrected protect classifications #557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a couple of small things:
SideCondition
s found inMove
s that weren't previously recorded (collected through regex filtering ofgen[1-9]moves.json
)move.side_condition
to return aSideCondition
object, consistent withTerrain
/Weather
/Effect
/Status
SideCondition
to ensure better maintainability, similar to what I did withvolatile_status
-- ensuring that if a newSideCondition
pops up, we will have it captured in the enum. Also ensuring that we don't have extraSideCondition
s not available in Showdownmove_generator
intest_move
so that we can more easily test different generations of moves to ensure multi-generational compatibility