Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding enumerations for the target property of moves #529

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Adding enumerations for the target property of moves #529

merged 7 commits into from
Apr 11, 2024

Conversation

caymansimpson
Copy link
Contributor

Adding enumerations for the .target() field in Move class, to make it easier to embed moves via OHE.

Changes:

  1. Created an enumeration class of Target
  2. Changed move.target to return this enumeration
  3. Added unit tests to test the enumeration
  4. Added unit tests to test target in moves

All unit tests passed in both test_move and test_enumeration

This is in response to issue #525, but only addresses the Target field because you already have encoded volatile statuses in effect.py

@caymansimpson
Copy link
Contributor Author

Please reject if you think this is not well-thought through. I'm not sure how this should best jive with Issue #523, and specifically the DoubleBattle implementation here and here

@hsahovic hsahovic force-pushed the master branch 2 times, most recently from 3e91154 to 78b3245 Compare April 6, 2024 22:28
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Merging #529 (2d4cf46) into master (f458350) will decrease coverage by 0.14%.
Report is 27 commits behind head on master.
The diff coverage is 89.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   83.38%   83.24%   -0.14%     
==========================================
  Files          39       40       +1     
  Lines        3918     3988      +70     
==========================================
+ Hits         3267     3320      +53     
- Misses        651      668      +17     

@hsahovic
Copy link
Owner

@caymansimpson thanks!

@hsahovic hsahovic merged commit 5ecfd5f into hsahovic:master Apr 11, 2024
7 of 8 checks passed
@caymansimpson caymansimpson deleted the enumerations branch April 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants