-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding enumerations for the target property of moves #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them into moves.py
Please reject if you think this is not well-thought through. I'm not sure how this should best jive with Issue #523, and specifically the DoubleBattle implementation here and here |
hsahovic
force-pushed
the
master
branch
2 times, most recently
from
April 6, 2024 22:28
3e91154
to
78b3245
Compare
hsahovic
reviewed
Apr 8, 2024
hsahovic
reviewed
Apr 8, 2024
hsahovic
reviewed
Apr 8, 2024
…m_showdown_message to Target, and to_showdown_target in DoubleBattle
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 83.38% 83.24% -0.14%
==========================================
Files 39 40 +1
Lines 3918 3988 +70
==========================================
+ Hits 3267 3320 +53
- Misses 651 668 +17 |
@caymansimpson thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding enumerations for the .target() field in Move class, to make it easier to embed moves via OHE.
Changes:
All unit tests passed in both test_move and test_enumeration
This is in response to issue #525, but only addresses the Target field because you already have encoded volatile statuses in effect.py