Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Always Depth Write" setting. One step forward for #8171 #9726

Merged
merged 2 commits into from
May 26, 2017

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented May 26, 2017

This option was only for working around a problem in Saint Seiya and Jeanne D'Arc on ES 2.0 devices where we can't blit depth buffers. Don't really think it's worth keeping, ES 2.0 devices are a diminishing part of the market and they are probably mostly not fast enough to run these games very well anyway.

#8171

@hrydgard hrydgard added this to the v1.5.0 milestone May 26, 2017
@zminhquanz
Copy link
Contributor

zminhquanz commented May 26, 2017

It is not necessary at present , a lot of game when i play was never checked that setting , because on GLES 2.0 device , not powerful enough to emulate well on these game, so i vote to remove it

Copy link
Collaborator

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a terrible workaround for Jeanne d'Arc anyway.

-[Unknown]

@unknownbrackets unknownbrackets merged commit 708a54d into master May 26, 2017
@hrydgard hrydgard deleted the remove-always-depth-write branch May 26, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants