Make const mipmaps more consistent #9678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since SLOPE is just a more complicated CONST, we can treat them the same.
|
Code looks good, only worry is as usual possible performance effects due to changes in flushing. Let's try it. |
|
Right. These are the affected games: I couldn't find where Grand Theft Auto was doing it. Valkyria was the only other one I had, and didn't see any real performance impact there (it seems to leave the slope register constant.) Of course, this only lists games using the SLOPE mode, so there might be some crazy game fiddling with the register for no reason, but never using it. Hopefully not... -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell, slope is entirely constant. It sorta makes sense if you think of the slope as the UV slope, and this is an alternative to AUTO using the calculated slope.
Senjou no Valkyria 3 uses this on lamps. I didn't find a case with a slope other than 0.015, but the bias is then varied between -2 and 0, which in other words varies the level between 0 and 1 (even though there are 7 mip levels.) Maybe there are areas that use other slope values... I only checked two maps using them.
Anyway, this makes slope and const equivalent (after adding slope to bias), and flushes when slope changes.
-[Unknown]