SoftGPU: Implement mipmapping #9673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several obvious issues in Crisis Core, but it's still wrong when texcoords go the other direction. Need to use the deltas.
A tiny bit faster.
These should only be used for CLUT4.
It seems like this is what the PSP does, or maybe this is just correcting for floating point error...
hrydgard
approved these changes
May 8, 2017
GPU/Software/Rasterizer.cpp
Outdated
| float detail; | ||
| switch (gstate.getTexLevelMode()) { | ||
| case GE_TEXLEVEL_MODE_AUTO: | ||
| detail = std::log2f(std::abs(std::max(ds, dt))); |
There was a problem hiding this comment.
optimization idea: instead of using the accurate log2f, pick apart the max(ds, dt) floating point number and use the exponent (biased appropriately) for the detail level and the mantissa as the interpolation factor towards the next one. I believe that's what most hardware implementations actually do.
There was a problem hiding this comment.
Sounds like a good plan. Wasn't worrying about optimization overly yet. Probably forgot <cmath> for log2f anyway...
-[Unknown]
There was a problem hiding this comment.
Yeah, as expected this gave a pretty decent improvement to performance - 68 -> 73 FPS in the #6357 animation.
-[Unknown]
|
Travis looks a bit unhappy, coincidentally it's about the log2f operation. |
This is probably what the hardware does and much faster.
These now affect softgpu, so let's not disable them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few things left to fix, but this largely implements all the mipmapping outlined in #9621. The animations in #6357 work roughly as expected.
Things that remain:
Crisis Core looks quite a bit better with this rounding. But, this does impact performance negatively overall.
-[Unknown]