GL: Optimize video uploads a bit #9485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if it has a larger texture it wants to reuse, it can control this via texcoords. Let's keep it at top left, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common case is that we're uploading a video with stride 512 to a 480 wide buffer. In GL, we end up shuffling the video into a temporary buffer before uploading - this cuts that off.
This also allows for more cases of reuse of the pixel texture (if we want to), mostly for DrawPixels(), rather than nuking on any size change, as we do currently.
Saw this while investigating #9262.
-[Unknown]