Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up branch of Xebra's hw tess #9226

Merged
merged 17 commits into from
Jan 23, 2017
Merged

Cleaned up branch of Xebra's hw tess #9226

merged 17 commits into from
Jan 23, 2017

Conversation

hrydgard
Copy link
Owner

Something has gone wrong with the merges in #9210 so I decided to just cherry-pick all the actual changes to a new branch for easier review and cleaner merge.

@hrydgard hrydgard mentioned this pull request Jan 23, 2017
@hrydgard hrydgard merged commit ce2feb2 into master Jan 23, 2017
@hrydgard hrydgard deleted the cleaned-up-hw-tess branch January 23, 2017 14:26
@DonelBueno
Copy link

DonelBueno commented Jan 25, 2017

It's not working properly for me.

Hardware tesselation:

1a- hardware tesselation
1b- hardware tesselation
2a- hardware tesselation
2b- hardware tesselation

Software tesselation:

1a- software tesselation
1b- software tesselation
2a- software tesselation
2b- software tesselation

System Specs:

Windows 10 Pro 64 bits
i7 980x @ 4.04 GHz
GTX 770 2GB, driver 376.60
12 GB DDR3

@LunaMoo
Copy link
Collaborator

LunaMoo commented Jan 25, 2017

Are you really using GTX 770 or maybe running of integrated intel HD by accident? Because this should work on amd/nvidia gpu's just fine, on most other stuff will probably just have to be disabled. Intel graphics have quite likely just as poor drivers on windows as gles devices on android.

Unless it's some windows 10 driver bug:|, what error does the log shows?

@DonelBueno
Copy link

DonelBueno commented Jan 25, 2017

My CPU doesn't have an integrated GPU. I'll check the log soon, thanks.

EDIT (the highlighted area corresponds to the glitchy part):

sem titulo

@LunaMoo
Copy link
Collaborator

LunaMoo commented Jan 25, 2017

Wasn't there anything earlier? Like actual errors printed with red colors?
Your screenshots with missing graphics look like a shader compilation failure, but this log doesn't really show anything related or even specially wrong. I think I'll relog to win 10 and see if my AMD gpu is affected, it's unfortunately working fine on win 7:].

@DonelBueno
Copy link

DonelBueno commented Jan 25, 2017

These errors showed upon opening the game:

1
2

Forgot to mention, using build v1.3-372-g524854a

@LunaMoo
Copy link
Collaborator

LunaMoo commented Jan 25, 2017

None of those are related;p. Also can't reproduce it with amd gpu even on win 10 with like half year old drivers(aka previous time I logged on it).

I can only guess it's at least partially the same thing as #9234 we'll have to improve this code to at least match GLSL specs, because it's now working only on pc's with better driver interpretation. And on some older devices this feature will most likely be completely disabled.

@DonelBueno
Copy link

Even after the merge of #9242, the glitch is still true. I'll try to update my drivers, this is really strange.

@DonelBueno
Copy link

DonelBueno commented Jan 29, 2017

My issue was fixed alongside issue #9249 =)

@xebra
Copy link
Contributor

xebra commented Jan 29, 2017

@DonelBueno Thank you for reporting :)

@hrydgard Nice work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants