Fix some mpeg issues #9014
Merged
Fix some mpeg issues #9014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to convince FFmpeg to read only the header, this was allowed to get longer. But we only really need the actual header here, and that can prevent FFmpeg mis-parsing later packets.
Before, we were only returning an error once, in an effort to log only once. This meant sometimes games would not realize they needed to add packets. Un-reverted from e866d83. No longer breaks Patapon with other mpeg fixes.
|
It fixes the video in Danball Senki W. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we were mistreating some data in the header in some cases - fixes #9002.
Additionally, c03f6c2 is reported to help #8991 and no longer breaks Patapon. I'm pretty sure it's correct, so I'm reintroducing it here.
-[Unknown]