Detect power saving mode on Android #8871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows a message when it's on, or when power drops to low.
Sometimes users don't realize these are on, and they can slow down gameplay. Of course, they can also save battery.
|
I know you and iOS ain't best friends, but could the Low Power Mode get detected on iOS? When LPM is on it actually underclocks the processor so it might be important to detect on iOS too. |
|
It sure could. Someone would just need to write the iOS-specific code to call this API and notify the PPSSPP core about low-power mode. It's intentionally been written so that other platforms can integrate easily. Pull requests accepted. -[Unknown] |
|
Nice one, to me little details like this one make PPSSPP look like a very serious app/project. |
|
@hrydgard how about this one ? |
|
Oh, was meaning to read it through but forgot about it. Looking at it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't affect games (although, it could), but instead most importantly notifies users.
I'm sure that low battery may notify users anyway, but power saving is more likely not to: I remember on my Galaxy S3 (which I no longer have), it was easy not to notice it was even on. This shows a message on startup when it is on.
Potentially we could send a low battery level to games which might in some rare cases influence how they render or something.
Anyway, this also disables sending reporting CRCs when power is low / in saving mode.
-[Unknown]