added easy import/export of roms and game saves for ios version [REVISED] #7885
Conversation
…d roms. started by creating a new window in Settings Tools section for starting the web server. Its called Import Export ROMs and Game Saves.
… within the cross platform code. also need to work on GUI window for explaining where to connect. server needs to be stopped once leaving the import export window.
…ng. now need to fully integrate with UI and provide help in app website for basic how to. also need ability to turn off and release
…ct and alterations that are different from what the b.sh generated. Will want to remove and modify build script at later point
…elp almost complete. just need to stop server when leaving dialog
… is turned off. will test tomorrow and if all is well submit a pull request with main repo.
…sily sync roms and game saves between the device and the computer
…r.bundle as part of the app resources. needs to be fixed otherwise need to manually add bundle to resource when building ios project
…sh to master repo
|
Also, I'm pretty sure the CI build failed because of the altered git sub module 'native'. You'll need to pull down the new codebase for native that I submitted a pull request for and use that in your test. A final update to the sub module with the new codebase link should fix that issue. |
|
|
||
|
|
||
|
|
||
| GCDWebUploader *webServer; |
There was a problem hiding this comment.
It's incorrect for this to be in the header. Any and all files that import this header will have their own copy instead of using a single shared copy. Did you mean to have extern GCDWebUploader *webServer; here, with GCDWebUploader *webServer; in the .m file?
|
See #8845 which implements a cross-platform UI to allow for retrieving ISOs from a desktop. It doesn't allow for local download though, but that is definitely possible. It also doesn't allow transfer of game saves. The implementation in this PR was definitely a good idea, but since we try to do things as cross-platform as possible, and unfortunately iOS (due to jit) is probably not our strongest platform already, I think the approach in #8845 might supersede. Don't think your contribution is ignored or bad because of this, though. -[Unknown] |
|
Closing as per above. -[Unknown] |
Hi, this is a revised pull request that includes the fixes that were discussed in the original pull request here:
#7881
The project now builds completely from CMake instead of checking in the build-ios/ directory. Tested building on different platforms and preprocess if directives and CMake build isolate iOS web server just for iOS.
One thing to note is that I also had to modify the native repo located here:
https://github.com/hrydgard/native
Here is the pull request related to that:
hrydgard/native#283
Let me know if there are any problems with this merge.