Replace frame download in Sakurasou No Pet Na Kanojo #6880
Conversation
|
Well, memcpy() should be doing this.... I guess it's too small chunks. Just to note, we want to avoid hooking in a loop, because if it's in a loop, it will cause a performance problem. We want to hook as early in the function as possible. I suppose hooking here with v0 would also do the trick? That should be outside the loop. -[Unknown] |
|
Look like get a half picture. |
|
Size change to 0x00088000 then it works. |
|
Yeah, if there's no register near there with 0x00088000 in it, then changing it is probably right. Before it was probably downloading every line below the top half in a row... slowly. Or possibly each and every row. Not sure how the function works exactly. -[Unknown] |
|
That A0 is 0x00088000. |
|
Hmm. Right after a jalr, a0 probably isn't "safe" to use. If no reg has it before the jalr, I guess it's better to hard code. -[Unknown] |
|
That a0 has a 0x88000 afetr changing the background,and no reg has it before the jalr. |
Replace frame download in Sakurasou No Pet Na Kanojo Conflicts: Core/HLE/ReplaceTables.cpp
As hrydgard said catch the memcpy. Fixes saveicons,the function https://gist.github.com/daniel229/ee3674788f4c560e8258