Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the hook for Kirameki School Life SP #6877

Merged

Conversation

daniel229
Copy link
Collaborator

Thanks unknown,as his suggestion hook its caller,it fixes another frame download issue in Kirameki School Life SP,and add a game to the comment which using the same function.

unknownbrackets added a commit that referenced this pull request Sep 11, 2014
Update the hook for Kirameki School Life SP
@unknownbrackets unknownbrackets merged commit 2e0df24 into hrydgard:master Sep 11, 2014
@unknownbrackets
Copy link
Collaborator

Can you link me to the line you're hooking on 0x304 (so i don't have to count manually)?

https://gist.github.com/daniel229/9dcefc10d7aac6399dee#file-func2-kirameki-school-life-sp-L89

Just click the line number and then paste the address here (or change L89 above to L123 according to the line number.)

-[Unknown]

@daniel229
Copy link
Collaborator Author

@unknownbrackets
Copy link
Collaborator

What if you do a2 at the top of the function (offset 0)?

https://gist.github.com/daniel229/9dcefc10d7aac6399dee#file-func2-kirameki-school-life-sp-L13

It looks like 0x2C(sp) is where s0 is ultimately coming from.

-[Unknown]

@daniel229
Copy link
Collaborator Author

Also works,but size should change to 88000

@unknownbrackets
Copy link
Collaborator

If a2 or something is 0x00088000, then maybe use that, otherwise hardcoding is probably fine (only concern is other games using the same func, really.)

-[Unknown]

@daniel229
Copy link
Collaborator Author

Is there a way to find out register value whether 0x00088000 rather than step over?

@unknownbrackets
Copy link
Collaborator

Hmm, not really. I would just set a breakpoint at that position and look at the regs.

-[Unknown]

@unknownbrackets
Copy link
Collaborator

When I said a2, I meant a1. Well, any reg at the start of the func. But I'll just hardcode for now.

-[Unknown]

@daniel229
Copy link
Collaborator Author

At the start of the func,no regs have 0x00088000.

@unknownbrackets
Copy link
Collaborator

Okay, sounds like it's fine to just use a2 and hardcode the size to 0x00088000.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants