Validate framebuffer uploads a bit more #6378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a reported crash on an AMD card.
|
Yes,it fixes #6377 |
|
What framebuffer address is it rendering too, then? It should say Creating FBO around where it crashed. -[Unknown] |
|
Is this? GLES\Framebuffer.cpp:973 Creating FBO for 08155f80 : 128 x 128 x 3 |
|
Hmm. That looks like a perfectly valid RAM address. I'm sure none of our code is prepared for RAM addresses as framebuffer addresses... I've never checked if you can draw to RAM after all, though... -[Unknown] |
|
that is the minimap |
|
After some extended testing (1 hour) with this branch, I can personally verify that this fixes the crash I reported at #6362 (comment) Nice work @unknownbrackets |
hrydgard
added a commit
that referenced
this pull request
Jun 21, 2014
Validate framebuffer uploads a bit more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash @solarmystic reported, might maybe help #6377 (but probably means a garbage address)?
-[Unknown]