Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Replace_memcpy crash #6248

Merged
merged 1 commit into from
Jun 7, 2014
Merged

Fix Replace_memcpy crash #6248

merged 1 commit into from
Jun 7, 2014

Conversation

sum2012
Copy link
Collaborator

@sum2012 sum2012 commented Jun 7, 2014

Fix Replace_memcpy crash in #5496
if do not use Replace_memcpy,the game still have problem
1

Fix Replace_memcpy crash in #5496
hrydgard added a commit that referenced this pull request Jun 7, 2014
@hrydgard hrydgard merged commit e69130b into hrydgard:master Jun 7, 2014
@sum2012
Copy link
Collaborator Author

sum2012 commented Jun 7, 2014

Does this fix better ?
sum2012@d669186

@hrydgard
Copy link
Owner

hrydgard commented Jun 7, 2014

Nope.

@sum2012
Copy link
Collaborator Author

sum2012 commented Jun 7, 2014

OK
edit:I asume it mean no

@unknownbrackets
Copy link
Collaborator

If we're going to do this we should probably at least log something, no? memcpy(0, src, size > 0) will definitely crash on a real PSP.

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented Jun 7, 2014

@sum2012 , yes, nope == no

@unknownbrackets , yeah. For consistency I guess if we should check one parameter we should check more - but I'm starting to change my mind about this one because the real memcpy doesn't check and it's "right" to crash - it would surely have crashed had we not replaced the function.

I suppose we should check if fastmem is off. Could even have separate functions for fastmem to avoid the check...

@sum2012
Copy link
Collaborator Author

sum2012 commented Jun 7, 2014

If turn off fast memory,now the game is playable.
We still need to solve "ReadFromHardware: Invalid address "
log: https://gist.github.com/sum2012/46bfbab83575078cd3a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants