Fix another race in multithread, and ge sync #5987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If EVENT_FINISH is received, but coreState is still CORE_RUNNING and the thread is still enabled, it would hang. Makes more sense to wait for events before processing them anyhow...
To prevent deadlock while debugging with events all running sync.
Erp, because of detach().
unknownbrackets
changed the title
And clarify logic.
hrydgard
added a commit
that referenced
this pull request
Apr 29, 2014
Fix another race in multithread, and ge sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If EVENT_FINISH is received, but coreState is still CORE_RUNNING and the thread is still enabled, it would hang. Makes more sense to wait for events before processing them anyhow...
Also ge sync was never running because detach wiped the id, of course...
-[Unknown]