Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate logging in sceUtility*GetStatus #5968

Merged
merged 2 commits into from
May 8, 2014
Merged

Avoid duplicate logging in sceUtility*GetStatus #5968

merged 2 commits into from
May 8, 2014

Conversation

sum2012
Copy link
Collaborator

@sum2012 sum2012 commented Apr 26, 2014

Fix Resistance Houfuku noToki draw slowly in OSK in debug log
#4626

@unknownbrackets
Copy link
Collaborator

Why not just try hleEatCycles() like savedata uses? But, it would be best to match the cycles it really takes.

I'm pretty sure this function does not block and reschedule.

-[Unknown]

@sum2012
Copy link
Collaborator Author

sum2012 commented Apr 27, 2014

@unknownbrackets Which value I use ?
100 need 5 second
200 need 3 second
400 need 2 second
600 need ~1.5 second

@unknownbrackets
Copy link
Collaborator

Is there a delay on a real PSP? I found while testing this on real hardware that the OSK takes unexpectedly long to come up on real hardware.

Those times are for debug only, right? I have not timed this function but I suspect it's similar to the savedata timing. For debug specifically, we could try avoid duplicate logging.

-[Unknown]

@sum2012
Copy link
Collaborator Author

sum2012 commented Apr 27, 2014

Yes real PSP ~ 1.5 second

@sum2012
Copy link
Collaborator Author

sum2012 commented Apr 27, 2014

Do this in sceUtilityOskGetStatus only ?

we could try avoid duplicate logging.

@@ -55,6 +55,7 @@ const int SCE_ERROR_MODULE_NOT_LOADED = 0x80111103;
const int SCE_ERROR_AV_MODULE_BAD_ID = 0x80110F01;
const u32 PSP_MODULE_NET_HTTP = 261;
const u32 PSP_MODULE_NET_HTTPSTORAGE = 264;
int oldStatus = 100; //random value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably declare as u32 then we don't need to change those for example &WrapU_U to &WrapI_U

@sum2012 sum2012 changed the title Fix Resistance Houfuku noToki draw slowly in OSK in debug log Avoid duplicate logging in sceUtility*GetStatus Apr 27, 2014
hrydgard added a commit that referenced this pull request May 8, 2014
Avoid duplicate logging in sceUtility*GetStatus
@hrydgard hrydgard merged commit 55f9e86 into hrydgard:master May 8, 2014
@sum2012
Copy link
Collaborator Author

sum2012 commented May 8, 2014

Thanks @hrydgard i almost forget this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants