Only copy dirty depth buffers between FBOs #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can remove this if/when we track them separately. This may break a game that depends on the depth carrying over between several FBOs, but that's not extremely likely. This improves performance in Gods Eater Burst.
hrydgard
added a commit
that referenced
this pull request
Jan 24, 2014
Only copy dirty depth buffers between FBOs
|
Seems worth trying. |
|
This effectively restores all lost performance in GEB on my system, making it perform at levels similar to the pre-blitting builds. Well done. v0.9.6-576-g7f99564 v0.9.6-574-g4789c24 Also helps restore performance in the God of War games. I would close #5070 but it seems like the current solution is only temporary and will be replaced with something else in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a hack.
We can remove this if/when we track them separately. This may break a game that depends on the depth carrying over between several FBOs, but that's not extremely likely.
This improves performance in Gods Eater Burst.
I've only really tested it with Jeanne d'Arc, I don't know if this hurts other games that were improved by the depth copying.
-[Unknown]