Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some video hang issues #5008

Closed
wants to merge 1 commit into from
Closed

Fix some video hang issues #5008

wants to merge 1 commit into from

Conversation

dbz400
Copy link
Contributor

@dbz400 dbz400 commented Jan 4, 2014

Looks like the original assumption is not good enough and return not expected pts value .This fixes video issue in "The Warrior" and "Dead Head Fred"

This fixes #5003

@hrydgard
Copy link
Owner

hrydgard commented Jan 4, 2014

Hm, returning video pts as audio timestamp also feels wrong... it doesn't break anything else, does it?

@dbz400
Copy link
Contributor Author

dbz400 commented Jan 4, 2014

I did try return m_audiopts , seems to be not working .I tested few other games with CG playback and looks fine though .

@unknownbrackets
Copy link
Collaborator

I'm assuming, since you were so sure Wild Arms XF is fine, that you have not bothered to check any of the games you tested to see if this causes audio desync issues. I don't think it's right to just blindly return obviously wrong values.

-[Unknown]

@dbz400
Copy link
Contributor Author

dbz400 commented Jan 4, 2014

Yep, i do think it is somehow not correct and may be only work in some cases though.However , at least we know they are related to pts .

@dbz400 dbz400 closed this Jan 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead Head Fred: video hang up
3 participants