Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more menu screen items translatable, and... #1911

Merged
merged 3 commits into from
May 26, 2013

Conversation

aquanull
Copy link
Contributor

...update font atlas files.
My fonts seem to lack some characters. No missing characters in UI menus or stock dialogs, though.

g_Config.iFpsLimit = 60;
if (UIButton(GEN_ID, hlinear1, 60, 0, "-30", ALIGN_LEFT))
if (UIButton(GEN_ID, hlinear1, 60, 0, gs->T("-30"), ALIGN_LEFT))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to translate numbers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to, were it to get involved with decimal marks or digital separators (not yet). We may also need to translate the arithmetical operators. It could be unnecessary in this line, though.

@ppmeis
Copy link
Contributor

ppmeis commented May 25, 2013

Maybe to be matter with #1904?

@aquanull
Copy link
Contributor Author

@hrydgard @raven02 Not everyone on the Earth uses the same arithmetical notation, and "2x" is not strictly syntactically correct in some languages like Chinese (should be "×2" or "2倍"), and needless to mention that "x" is not even the correct multiplication/times sign (should be "×"). "+30" and "-30" might be unneccessary to translate.

@lg560852
Copy link
Contributor

Alt Text
In my opinion, "2倍分辨率渲染" is Okey. But it looks like too long if in the android version. :<

@hrydgard
Copy link
Owner

Okay, you've convinced me :)

hrydgard added a commit that referenced this pull request May 26, 2013
Make more menu screen items translatable, and...
@hrydgard hrydgard merged commit 0f38192 into hrydgard:master May 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants