-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more menu screen items translatable, and... #1911
Conversation
g_Config.iFpsLimit = 60; | ||
if (UIButton(GEN_ID, hlinear1, 60, 0, "-30", ALIGN_LEFT)) | ||
if (UIButton(GEN_ID, hlinear1, 60, 0, gs->T("-30"), ALIGN_LEFT)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to translate numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to, were it to get involved with decimal marks or digital separators (not yet). We may also need to translate the arithmetical operators. It could be unnecessary in this line, though.
Maybe to be matter with #1904? |
@hrydgard @raven02 Not everyone on the Earth uses the same arithmetical notation, and "2x" is not strictly syntactically correct in some languages like Chinese (should be "×2" or "2倍"), and needless to mention that "x" is not even the correct multiplication/times sign (should be "×"). "+30" and "-30" might be unneccessary to translate. |
Okay, you've convinced me :) |
Make more menu screen items translatable, and...
...update font atlas files.
My fonts seem to lack some characters. No missing characters in UI menus or stock dialogs, though.