Game info screen: Add checks against the Redump database #18377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
redump-verification
branch
from
ac23c26 to
23ce34e
Compare
|
Super-minor, but other overloads of |
|
Also, unused parameter |
It's GREAT to see the oldest issues being fixed. |
|
Let's get this in and see how it works for people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReDump project keeps a database of title names, IDs and hashes of nearly all PSP games (and games for a lot of other platforms).
This adds a way to check your ISO against it, to make sure you managed to dump your UMD to ISO correctly through your PSP. By default, it just checks the ID and size, and if those are OK it'll show a notice to click Calculate CRC to verify. If not, it immediately shows a warning.
Needs a bit more polish before it goes in, both UI and code-wise.
We may consider doing a size check and warning users for bad ISOs on boot too, not just in the game info screen.
Fixes #12469