Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some debug overlays don't make sense when not in-game, disable them #17902

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

hrydgard
Copy link
Owner

Minor feedback fixes too.

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Aug 13, 2023
@hrydgard hrydgard added this to the v1.16.0 milestone Aug 13, 2023
@unknownbrackets unknownbrackets merged commit 87668a5 into master Aug 13, 2023
@unknownbrackets unknownbrackets deleted the ui-bugfixes branch August 13, 2023 20:13
@IrfanH495
Copy link

sorry I want to ask does this fix the issue in my comment.? #17878

@hrydgard
Copy link
Owner Author

@IrfanH495 Yeah it does, should have mentioned that more clearly.

Some of the other overlay types intentionally display over the menu though, so I can debug issues there.

@IrfanH495
Copy link

Ok thanks, I tried the last build showing up in the menu and missing in the game https://youtu.be/Mt6qvh6u3aU

@hrydgard
Copy link
Owner Author

Oh, hah, may have flipped it ... thought I tested it though :/ I'll fix it up.

@EdHerdman
Copy link

I get "Sas not initialized" when trying to bring up the Debug Stats overlay, which seems a bit cryptic. The frametimes graph is empty, but "Frame timing" still works (which I like, I find it interesting to see how much time Submit/Queue-p takes without a game loaded).

Apologies if it's off-topic but I've also been wondering about the eight side-by-side counters in the "frame timing" overlay. Is that intentional?

@hrydgard
Copy link
Owner Author

The debug stats should only be visible in-game, it's currently a bug so it's the other way around, resulting in the error.

The eight counters are the last 8 frames.

All of this is early preparation for some important changes to how timing works, and it'll change and I'll probably present it in cleaner ways as we go.

Stay tuned for updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants