ControlMapper: Change the callbacks to be more suitable for the upcoming refactor. #17209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
Input/Controller
Core/HLE/sceCtrl.cpp
Outdated
Comment on lines
207
to
210
| void __CtrlSetAllButtons(u32 buttonBits) | ||
| { | ||
| std::lock_guard<std::mutex> guard(ctrlMutex); | ||
| ctrlCurrent.buttons = buttonBits & CTRL_MASK_USER; |
There was a problem hiding this comment.
Not everything goes through the control mapper, such as API events and tilt. I think it'd be much better if this took two parameters, one to clear and one to set.
That way if the API is setting X pressed and the user is not doing anything, it won't incorrectly clear it. Currently, this would incorrectly clear it AFAICT.
-[Unknown]
There was a problem hiding this comment.
That's a good point, and will fit well with my WIP code. Will change before merging this.
unknownbrackets
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bunch of minor changes broken out, for easier reviewing and bisection.