Restore settings to default - let you choose what to reset #16878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #16381 , though could make even more granular later. The only translation change was deleting one sentence from a longer string - used Google Translate to assist me in removing the correct part for a few of them, most were obvious. Hope they're all right.
hrydgard
changed the title
|
This is one of the best settings i saw. Never saw this in any emulator/program before. I hope this becomes a trend. WAY BETTER than deleting the .ini file and start to configurate everything again. |
|
I have no way to test this rn, but does it works? I mean if you delete Game settings it nuke the ini with the recent iso too afaict, how do they survive the load call? Seems weird, but I'm probably just missing something :) |
|
Hm. You're right, this is not actually working correctly, I deluded myself to think it would because of the separate recent clearing in the RestoreDefaults function. I'll fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple. Fixes #16381, though could be made more granular.
Also does some refactoring so commits are to be reviewed separately.
(though need to tweak the layout a little...)