Memory exceptions: Keep track of access size #16695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might theoretically help in tracking some things down. Not fully utilized yet, the fault handler needs to extract the information from the faulting instruction. But we can use it for GetPointerRange etc.
unknownbrackets
approved these changes
Jan 1, 2023
hrydgard
force-pushed
the
memory-exception-report-size
branch
from
39002dc to
700a018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report the size of bad accesses when available.
Note that there's some future work to do here in the memory fault handler to extract the access size from the instruction.