Make fog-enable driven by uniform instead of fragment shader flag bit #16628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
remove-fog-fshader-flag
branch
from
9979a4f to
69f6109
Compare
unknownbrackets
approved these changes
Dec 30, 2022
hrydgard
force-pushed
the
remove-fog-fshader-flag
branch
from
69f6109 to
3dbe69f
Compare
| @@ -9,7 +9,7 @@ | |||
| enum : uint64_t { | |||
| DIRTY_BASE_UNIFORMS = | |||
| DIRTY_WORLDMATRIX | DIRTY_PROJTHROUGHMATRIX | DIRTY_VIEWMATRIX | DIRTY_TEXMATRIX | DIRTY_ALPHACOLORREF | | |||
| DIRTY_PROJMATRIX | DIRTY_FOGCOLOR | DIRTY_FOGCOEF | DIRTY_TEXENV | DIRTY_STENCILREPLACEVALUE | | |||
| DIRTY_PROJMATRIX | DIRTY_FOGCOLOR | DIRTY_TEXENV | DIRTY_STENCILREPLACEVALUE | | |||
There was a problem hiding this comment.
Hm, should DIRTY_FOGCOEFENABLE be here? Isn't it still in the base uniforms?
-[Unknown]
There was a problem hiding this comment.
Hm, yes, it seems to be an oversight. Will fix.
hrydgard
added a commit
that referenced
this pull request
Jan 5, 2023
Spotted by Unknown in #16628 comments.
5 tasks
5 tasks
hrydgard
added a commit
that referenced
this pull request
May 9, 2023
Revert "Merge pull request #16628 from hrydgard/remove-fog-fshader-flag"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16567, to be merged after 1.14.x .
No way this is a perf regression on any hardware, heh. Really good reduction of the fragment shader count in several big games, leading to less shader stutter.
Not sure what the best "flag values" in the coef would be, or if we should consume an extra bool.
Will bump the shader cache ID when this is merged together with the other similar changes.