softgpu: Fix w culling of triangles combined as rectangles #16509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
force-pushed
the
softgpu-rectw
branch
from
7d73d26 to
94b43c6
Compare
unknownbrackets
force-pushed
the
softgpu-rectw
branch
from
94b43c6 to
5d6b213
Compare
|
This may help Vampire Chronicles performance decrease in recently build? |
|
Oh, didn't know it slowed down, I guess we fell off the fast path for that one again.. Don't think it's likely this will fix it, I'll create a separate issue. |
hrydgard
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has actually existed for a while, but wasn't fixed by the recent learnings for w culling because of the triangles being optimized to a rectangle. Fixes some effects in Kingdom Hearts (see #16131.)
The clipping one is less likely, mainly for non-textured rectangles, but I'd rather not fight with a weird bug for that either.
-[Unknown]