headless: Update tests and fix crash running tests on Vulkan #16256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ended up with a cropped screenshot for a frame dump, which just silently crashed. Could reject, but easy enough to support.
If there's no frame display, tests were crashing because no backbuffer present blit happened. This allows those tests to run.
hrydgard
approved these changes
Oct 19, 2022
|
Great! Now PPSSPP can run game with vulkan on my PC. But still popup 2 error dialogboxes after closing, |
|
This probably didn't fix anything for Vulkan unless you're using the headless tool (which doesn't display graphics, it is for running tests.) A prior commit must've fixed it. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the GPU-related tests that didn't end up presenting (list running, etc.) were crashing on Vulkan.
This also includes 2 newly passing tests from #16241. Didn't even realize it fixed them.
-[Unknown]